grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GRUB PARTUUID PATCH V3 5/5] Harmonize patches


From: Andrei Borzenkov
Subject: Re: [GRUB PARTUUID PATCH V3 5/5] Harmonize patches
Date: Mon, 27 Feb 2017 21:03:11 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

27.02.2017 03:34, Vladimir 'phcoder' Serbinenko пишет:
>>    if (state[6].set)
>>      {
>>        char *partuuid = NULL; /* NULL to silence a spurious GCC warning */
>> -      /* Nested partitions are not supported for now. */
>> -      /* Non-nested partitions must have dev->disk->partition->parent ==
>> NULL */
>> -      if (dev->disk && dev->disk->partition &&
>> dev->disk->partition->parent == NULL)
>> +      /*
>> +       * Nested partitions are not supported for now.
>> +       * Non-nested partitions must have dev->disk->partition->parent ==
>> NULL
>> +       */
>>
> I'm not sure that this is enough. In presence of nested partitions Linux
> may shift extended partitions as well. I think we need to do tests with
> qemu and bsd-formatted partitions
> 

In my testing Linux never sees nested partitions (it never scans
partitions for nested partitions). For all I can tell this check has
been there at least since 2006 (I'm lacy to look beyond introduction of
block/ directory).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]