Re: [GRUB PARTUUID PATCH V5 1/3] Update grub_gpt_partentry; centralize guid prints

[Nick Vinson]

Sorry for the delay in responding.  I just now saw these replies.

On 02/20/2018 09:30 AM, Daniel Kiper wrote:
> On Sun, Feb 04, 2018 at 11:47:35AM -0800, Nicholas Vinson wrote:
>> To help clean the code and simplify the code in util/grub-probe.c, this
>> patch renames grub_gpt_part_type to grub_gpt_part_guid and updates
>> grub_gpt_partentry to use this type for both the partition type GUID
>> string and the partition GUID string entries.
>>
>> This patch also moves the GUID printing logic in util/grub-probe.c to a
>> separate function.  This change allows the partuuid logic in the next
>> commit to use the same printing logic without having to completely
>> duplicate it.
> 
> One logical change per patch please...

Done.  I've split this patch into two.

> And please add your SOB next time.

Done.  I'll submit a version 6 shortly.

Thanks,
Nicholas Vinson
> 
> Daniel
>

signature.asc
Description: OpenPGP digital signature