Re: [PATCH v6] probe: Support probing for partition UUID with --part-uuid

[Paul Menzel]

Dear Jacob,


On 05/15/2019 07:20 AM, Jacob Kroon wrote:
> Linux supports root=PARTUUID=<partuuid> boot argument, so add
> support for probing it. Compared to the fs UUID, the partition
> UUID does not change when reformatting a partition.
> 
> For now, only disks using a GPT partition table are supported.

Should that be also mentioned in the documentation?

> Signed-off-by: Jacob Kroon <address@hidden>
> ---
>  docs/grub.texi             |  2 +-
>  grub-core/commands/probe.c | 34 ++++++++++++++++++++++++++++++++++
>  2 files changed, 35 insertions(+), 1 deletion(-)
> 
> Changes since v5:
>  * Remove short option
>  * partition UUID is not necessarily restricted to GPT, so clarify that
>    in the help text and commit message

Thank you very much for going through the reviews so quickly.

This looks good to me, and the support can be extended later on.

Reviewed-by: Paul Menzel <address@hidden>


Kind regards,

Paul

smime.p7s
Description: S/MIME Cryptographic Signature