Re: [PATCH v3 00/10] Cryptodisk fixes for v2.06 redux

[Daniel Kiper]

On Mon, Oct 19, 2020 at 06:09:48PM -0500, Glenn Washburn wrote:
> Heres an updated patch series which addresses comment from Patrick. The only
> code change is adding a slot_key member to grub_luks2_keyslot and using that
> instead of an extra out parameter to luks2_get_keyslot.
>
> Glenn Washburn (10):
>   luks2: Fix use of incorrect index and some grub_error() messages.
>   luks2: Improve readability in luks2_get_keyslot.
>   luks2: Use more intuitive keyslot key instead of index when naming
>     keyslot.
>   luks2: grub_cryptodisk_t->total_length is the max number of device
>     native sectors
>   cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'.
>   cryptodisk: Properly handle non-512 byte sized sectors.
>   cryptodisk: Replace some literals with constants in
>     grub_cryptodisk_endecrypt.
>   cryptodisk: Rename total_length field in grub_cryptodisk_t to
>     total_sectors.
>   cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors.
>   luks2: Rename source disk variabled named 'disk' to 'source' as in
>     luks.c.

Most of LUKS2 patches require rework. The rest which got Patrick's and
my RB I will push into the GRUB git repo by the end of this week. Of
course if there are no objections...

Daniel