[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] error: Do compile-time format string checking on grub
From: |
Glenn Washburn |
Subject: |
Re: [PATCH v2 0/2] error: Do compile-time format string checking on grub_error. |
Date: |
Mon, 23 Nov 2020 03:31:23 -0600 |
On Sat, 7 Nov 2020 23:26:17 -0600
Glenn Washburn <development@efficientek.com> wrote:
> I've separated this into two patches from the previous one, but
> nothing else has changed (except the commit message). I think at
> least the first patch should be applied. Since I don't have a setup
> to test every architecture+platform build of grub, I can't gaurantee
> that the second patch won't cause a build error on some other
> architecture+platform combo. However, if it does, I'll bet it'll get
> fixed quickly. However, for that reason, I suggest the second patch
> be applied after the 2.06 release (might be moot at this point). This
> series has successfully built for me for i386-pc and x86_64-efi.
>
Daniel, have you had a chance to take a look at these? If so, is there
anything I can do to help get these merged?
Glenn
> Glenn Washburn (2):
> error: Fix issues mostly related to incorrect length modifiers in
> calls to grub_error().
> error: Do compile-time format string checking on grub_error.
>
> grub-core/commands/pgp.c | 2 +-
> grub-core/disk/ata.c | 4 ++--
> grub-core/disk/cryptodisk.c | 14 ++++++++------
> grub-core/disk/dmraid_nvidia.c | 2 +-
> grub-core/disk/luks2.c | 6 +++---
> grub-core/efiemu/i386/loadcore64.c | 3 ++-
> grub-core/fs/hfsplus.c | 3 ++-
> grub-core/fs/zfs/zfs.c | 2 +-
> grub-core/kern/efi/efi.c | 2 +-
> grub-core/kern/efi/mm.c | 2 +-
> grub-core/kern/x86_64/dl.c | 2 +-
> grub-core/loader/efi/chainloader.c | 4 ++--
> grub-core/loader/i386/bsd.c | 3 ++-
> grub-core/loader/i386/pc/linux.c | 4 ++--
> grub-core/net/tftp.c | 2 +-
> grub-core/parttool/msdospart.c | 4 ++--
> grub-core/script/lexer.c | 2 +-
> grub-core/video/bochs.c | 4 ++--
> include/grub/err.h | 3 ++-
> 19 files changed, 37 insertions(+), 31 deletions(-)
>