[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 10/12] mips: Enable __clzdi2()
|
From: |
Glenn Washburn |
|
Subject: |
Re: [PATCH v6 10/12] mips: Enable __clzdi2() |
|
Date: |
Thu, 3 Dec 2020 09:58:40 -0600 |
On Thu, 3 Dec 2020 15:00:14 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:
> On Fri, Nov 27, 2020 at 03:03:42AM -0600, Glenn Washburn wrote:
> > This patch is similiar to commit 9dab2f51e (sparc: Enable
> > __clzsi2() and __clzdi2()) but for MIPS target and __clzdi2 only,
> > __clzsi2 was already enabled.
> >
> > Signed-off-by: Daniel Kiper <dkiper@net-space.pl>
>
> This should be replaced with:
>
> Suggested-by: Daniel Kiper <daniel.kiper@oracle.com>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> In general if somebody suggests you something and you use they idea
> then you should use Suggested-by instead of SOB.
>
> Anyway, I can fix it before committing the patch if you are OK with me
> adding your SOB.
Sure, I'm fine with you adding my SOB. I don't know if you're not
taking finished patches that come after unfinished patches, so I was
just going to fix and include in my next iteration. If you're ready to
take these patches, then go ahead and I'll have less patches in the v7
series.
Glenn