[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm-coreboot: Declare global struct ps2_state as static so s
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] arm-coreboot: Declare global struct ps2_state as static so symbols don't cause link failure |
|
Date: |
Fri, 4 Dec 2020 13:30:45 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Dec 03, 2020 at 12:10:26AM -0600, Glenn Washburn wrote:
> This appears to be a new issue surfaced by switching from gcc 9.3.0 to
> 10.1.0 cross compiling toolchain. When linking these two object files
> together, there is an error generated: "multiple definition of `ps2_state'".
> This only appears to be an issue when --target=arm-linux-gnueabi and
> --with-platform=coreboot. There's no need for these structs to have global
> as opposed to file scope, so declaring them as static fixes this issue.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
> grub-core/term/arm/cros.c | 2 +-
> grub-core/term/arm/pl050.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
The same patch is in this [1] patch series. I will add your SOB there
and merge the patches into master next week.
Daniel
[1] https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00044.html