[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2.06 RELEASE 2/3] i18n: Align N_() formatting with the rest o
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH 2.06 RELEASE 2/3] i18n: Align N_() formatting with the rest of GRUB code |
|
Date: |
Fri, 23 Apr 2021 17:49:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/14/21 5:48 PM, Daniel Kiper wrote:
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> grub-core/commands/ls.c | 2 +-
> grub-core/commands/terminal.c | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c
> index 326d2d6b4..8e98c73cc 100644
> --- a/grub-core/commands/ls.c
> +++ b/grub-core/commands/ls.c
> @@ -70,7 +70,7 @@ grub_ls_list_devices (int longlist)
> FOR_NET_APP_LEVEL (proto)
> {
> if (first)
> - grub_puts_ (N_ ("Network protocols:"));
> + grub_puts_ (N_("Network protocols:"));
Is part of the coding style that functions calls should have a space between
the function name and the parenthesis but not when using macros ? I haven't
found anything about it in the docs/grub-dev.texi file.
But it's true that this change makes it consistent with the rest of the GRUB
codebase, so the patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat