Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

[Daniel Kiper]

On Thu, Apr 29, 2021 at 11:05:20AM +0200, Carlos Maiolino wrote:
> On Thu, Apr 22, 2021 at 05:15:31PM +0200, Javier Martinez Canillas wrote:
> > Hello Vladimir,
> >
> > On 4/22/21 4:56 PM, Vladimir 'phcoder' Serbinenko wrote:
> > > Filesystems are not mounted in GRUB. This patch will result in GRUB
> > > outputting a warning on every access to any XFS that has this flag set,
> > > even if it is not related to further booting. It will create an excessive
> > > noise. FS drivers shouldn't print anything except dprintf's
>
> I see. Good to know, thanks for the information.
>
> > Do you think we should just ignore the flag then and drop this patch or it 
> > is
> > worth to have some debugging printouts with grub_dprintf("xfs", ... ) ?
>
> If I understand this correctly, grub can simply ignore the flag, which will 
> make
> it attempt to read the filesystem anyway.
>
> Although, if it fails to read the FS for 'some reason', maybe it can print out
> a debug message then saying such flag was set in the filesystem? This may give
> some extra information to the user?!

I think it is good idea. Could you prepare a patch?

Daniel