Re: boot/grub2: grub-core-build-fixes-for-i386 (grub-2.04 + binutils-2.35.2 + pseudo-op .code64)

[Daniel Kiper]

Hi Jan,

On Thu, May 13, 2021 at 12:35:25PM +0200, Jan Nieuwenhuizen wrote:
> Daniel Kiper writes:
>
> Hello Daniel,
>
> > May I ask you to try latest GRUB master git branch [1]? The GRUB 2.04
> > release is a few years old. We are going to release 2.06 soon.
>
> Sure.  The bug is still there (see attached patch to reproduce using
> Guix):
>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix build --system=i686-linux --target=i586-pc-gnu grub
> starting phase `unpack'
> grub-2.06~rc1/
> [..]
> starting phase `configure'
> source directory: "/tmp/guix-build-grub-2.06-rc1.drv-0/grub-2.06~rc1" 
> (relative from build: ".")
> build directory: "/tmp/guix-build-grub-2.06-rc1.drv-0/grub-2.06~rc1"
> configure flags: ("CC_FOR_BUILD=gcc" 
> "CONFIG_SHELL=/gnu/store/v1g7f3p4f0851mywrla8qmr9hb8jgfjr-bash-minimal-5.0.16/bin/bash"
>  
> "SHELL=/gnu/store/v1g7f3p4f0851mywrla8qmr9hb8jgfjr-bash-minimal-5.0.16/bin/bash"
>  "--prefix=/gnu/store/753q8z0xa9ijap3p3phpsvns7287c7sn-grub-2.06-rc1" 
> "--enable-fast-install" "--build=i686-unknown-linux-gnu" "--host=i586-pc-gnu" 
> "PYTHON=true")
> [..]
> starting phase `build'
> [..]
> i586-pc-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -Wall -W  -DGRUB_MACHINE_PCBIOS=1 
> -DGRUB_MACHINE=I386_PC -m32 -nostdinc -isystem 
> /gnu/store/q8af3pvwsknn132pl1nzrb5281i4pgij-gcc-cross-i586-pc-gnu-7.5.0-lib/lib/gcc/i586-pc-gnu/7.5.0/include
>  -I../include -I../include -DGRUB_FILE=\"lib/i386/relocator.c\" -I. -I. -I.. 
> -I.. -I../include -I../include -I../grub-core/lib/libgcrypt-grub/src/    
> -D_FILE_OFFSET_BITS=64 -std=gnu99 -Os -m32 -Wall -W -Wshadow -Wpointer-arith 
> -Wundef -Wchar-subscripts -Wcomment -Wdeprecated-declarations 
> -Wdisabled-optimization -Wdiv-by-zero -Wfloat-equal -Wformat-extra-args 
> -Wformat-security -Wformat-y2k -Wimplicit -Wimplicit-function-declaration 
> -Wimplicit-int -Wmain -Wmissing-braces -Wmissing-format-attribute -Wmultichar 
> -Wparentheses -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wswitch 
> -Wtrigraphs -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label 
> -Wunused-parameter -Wunused-value  -Wunused-variable -Wwrite-strings 
> -Wnested-externs -Wstrict-prototypes -g -Wredundant-decls 
> -Wmissing-prototypes -Wmissing-declarations  -Wextra -Wattributes 
> -Wendif-labels -Winit-self -Wint-to-pointer-cast -Winvalid-pch 
> -Wmissing-field-initializers -Wnonnull -Woverflow -Wvla -Wpointer-to-int-cast 
> -Wstrict-aliasing -Wvariadic-macros -Wvolatile-register-var -Wpointer-sign 
> -Wmissing-include-dirs -Wmissing-prototypes -Wmissing-declarations -Wformat=2 
> -march=i386 -mrtd -mregparm=3 -falign-jumps=1 -falign-loops=1 
> -falign-functions=1 -freg-struct-return -mno-mmx -mno-sse -mno-sse2 -mno-sse3 
> -mno-3dnow -msoft-float -fno-dwarf2-cfi-asm -mno-stack-arg-probe 
> -fno-asynchronous-unwind-tables -fno-unwind-tables -fno-ident 
> -fno-stack-protector -Wtrampolines -Werror   -ffreestanding   -MT 
> lib/i386/relocator_module-relocator.o -MD -MP -MF 
> lib/i386/.deps-core/relocator_module-relocator.Tpo -c -o 
> lib/i386/relocator_module-relocator.o `test -f 'lib/i386/relocator.c' || echo 
> './'`lib/i386/relocator.c
> lib/i386/relocator64.S: Assembler messages:
> lib/i386/relocator64.S:66: Error: unknown pseudo-op: `.code64'
> lib/i386/relocator64.S:74: Error: bad register name `%rax'
> lib/i386/relocator64.S:98: Error: bad register name `%rax'
> lib/i386/relocator64.S:132: Error: bad register name `%rip)'
> --8<---------------cut here---------------end--------------->8---

[...]

> > A patch should be prepared on top of latest GRUB master git branch [1].
>
> Sure, but well..
>
>     https://lists.gnu.org/archive/html/bug-grub/2020-06/msg00013.html
>
> it was when I sent the report ;)

Sorry, I missed it...

> Luckily it still applied cleanly to current master.

Great!

> > And please use "git-send-email" to send the patch as Adrian said...
>
> Sure, sent separately to bug-grub.

I cannot find your updated patch. May I ask you to send it using
"git-send-email" to grub-devel@gnu.org?

Daniel