[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/9] tests: Do not occlude subshell error codes when used
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v4 4/9] tests: Do not occlude subshell error codes when used as input to the test command |
|
Date: |
Thu, 14 Oct 2021 13:27:11 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Oct 12, 2021 at 07:39:58PM -0500, Glenn Washburn wrote:
> When using the output of a subshell as input, its error code is ignored in
> the context of "set -e". Many test scripts use grub-shell in a subshell with
> output used as an argument to the test command to test for expected output.
> Refactor these tests so that the subshell output goes to a shell variable,
> so that if the subshell errors the script will immediately exit with an
> error code.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
- [PATCH v4 0/9] Various fixes/improvements for tests, Glenn Washburn, 2021/10/12
- [PATCH v4 7/9] tests: A failure of mktemp should cause the test script to exit with code 99, Glenn Washburn, 2021/10/12
- [PATCH v4 8/9] tests: Exit with skipped exit code when test not performed, Glenn Washburn, 2021/10/12
- [PATCH v4 3/9] tests: Add set -e to missing tests, Glenn Washburn, 2021/10/12
- [PATCH v4 5/9] tests: Do not occlude grub-shell return code, Glenn Washburn, 2021/10/12
- [PATCH v4 1/9] tests: Fix partmap_test for arm*-efi, disk numbering has changed, Glenn Washburn, 2021/10/12
- [PATCH v4 2/9] tests: When checking squashfs fstime, use superblock last modified time, Glenn Washburn, 2021/10/12
- [PATCH v4 4/9] tests: Do not occlude subshell error codes when used as input to the test command, Glenn Washburn, 2021/10/12
- Re: [PATCH v4 4/9] tests: Do not occlude subshell error codes when used as input to the test command,
Daniel Kiper <=
- [PATCH v4 6/9] tests: Make setup errors in grub-fs-tester hard errors, Glenn Washburn, 2021/10/12
- [PATCH v4 9/9] tests: Use @BUILD_SHEBANG@ autoconf var instead of literal shell, Glenn Washburn, 2021/10/12