Re: [PATCH] minilzo: Update to minilzo-2.10

[Daniel Kiper]

On Sun, Nov 28, 2021 at 11:54:28PM +0000, Colin Watson wrote:
> minilzo fails to build on a number of Debian release architectures
> (armel, mips64el, mipsel, ppc64el) with errors such as:
>
>   ../../grub-core/lib/minilzo/minilzo.c: In function 'lzo_memops_get_le16':
>   ../../grub-core/lib/minilzo/minilzo.c:3479:11: error: dereferencing 
> type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
>    3479 |         * (lzo_memops_TU2p) (lzo_memops_TU0p) (dd) = * (const 
> lzo_memops_TU2p) (const lzo_memops_TU0p) (ss); \
>         |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   ../../grub-core/lib/minilzo/minilzo.c:3530:5: note: in expansion of macro 
> 'LZO_MEMOPS_COPY2'
>    3530 |     LZO_MEMOPS_COPY2(&v, ss);
>         |     ^~~~~~~~~~~~~~~~
>
> The latest upstream version is 2.10, so updating to it seems like a good
> idea on general principles, and it fixes builds on all the above
> architectures.
>
> The update procedure documented in the GRUB Developers Manual worked; I
> just updated the version numbers to make it clear that it's been
> executed recently.
>
> Signed-off-by: Colin Watson <cjwatson@debian.org>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel