[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 5/7] grub-core/net/net.c: Fix uninitialized scalar variable
From: |
Alec Brown |
Subject: |
[PATCH v2 5/7] grub-core/net/net.c: Fix uninitialized scalar variable |
Date: |
Mon, 21 Mar 2022 02:29:00 -0400 |
In the function grub_net_ipv6_get_link_local(), grub_net_network_level_address_t
addr is called but isn't being initialized. This results in the member
grub_dns_option_t option being filled with junk data from the stack. We can
prevent this by setting the option member in addr to 0.
Fixes: CID 375033
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
grub-core/net/net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 4d3eb5c1a..b6eb1f951 100644
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -292,6 +292,7 @@ grub_net_ipv6_get_link_local (struct grub_net_card *card,
addr.type = GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV6;
addr.ipv6[0] = grub_cpu_to_be64_compile_time (0xfe80ULL << 48);
addr.ipv6[1] = grub_net_ipv6_get_id (hwaddr);
+ addr.option = 0;
FOR_NET_NETWORK_LEVEL_INTERFACES (inf)
{
--
2.27.0
- [PATCH v2 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Alec Brown, 2022/03/21
- [PATCH v2 4/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 6/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 5/7] grub-core/net/net.c: Fix uninitialized scalar variable,
Alec Brown <=
- [PATCH v2 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- Re: [PATCH v2 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Darren Kenny, 2022/03/21