Re: [PATCH v4 1/2] lsefi: fixed memory leaks

[Glenn Washburn]

On Thu,  1 Sep 2022 09:28:53 +0200
Renaud Métrich <rmetrich@redhat.com> wrote:

> Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
> ---
>  grub-core/commands/efi/lsefi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
> index f46ba3b49..241be79f9 100644
> --- a/grub-core/commands/efi/lsefi.c
> +++ b/grub-core/commands/efi/lsefi.c
> @@ -136,8 +136,12 @@ grub_cmd_lsefi (grub_command_t cmd __attribute__ 
> ((unused)),
>                        (unsigned) protocols[j]->data4[7]);
>       }
>  
> +      if (protocols)
> +     grub_efi_free_pool (protocols);

This has the same issue that Daniel mentioned on a prior version of
this series, namely that GRUB has no function named
grub_efi_free_pool(). I think it would be a good idea to add one
though. In the future, I recommend rebasing your patches onto the GRUB
master branch before submitting patches to the list. It appears as
though you're still using a branch with Redhat specific patches on it.

Glenn

>      }
>  
> +  grub_free (handles);
> +
>    return 0;
>  }
>