grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Fix __clzsi2 logic


From: Daniel Kiper
Subject: Re: [PATCH v2] Fix __clzsi2 logic
Date: Mon, 10 Oct 2022 22:29:38 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Mon, Oct 10, 2022 at 09:43:20AM -0700, Tuan Phan wrote:
> On Mon, Oct 3, 2022 at 11:30 AM Tuan Phan <tphan@ventanamicro.com> wrote:
>      Fix the incorrect return value of __clzsi2 function.
>
>      Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz")
>      Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
>      Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>      ---
>      V2: Drop redundant brackets
>      Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
>      ---
>       grub-core/kern/compiler-rt.c | 2 +-
>       1 file changed, 1 insertion(+), 1 deletion(-)
>
>      diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-
>      rt.c
>      index 2057c2e0c..738bb8420 100644
>      --- a/grub-core/kern/compiler-rt.c
>      +++ b/grub-core/kern/compiler-rt.c
>      @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)
>
>         for (; j; j >>= 1)
>           {
>      -      if ((temp = val) >> j)
>      +      if (temp = (val >> j))
>               {
>                 if (j == 1)
>                   {
>      --
>      2.25.1
>
> Hi Daniel,
> Any chances that this patch will be merged soon? 

It has been merged together with other patches last week.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]