grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 0/2] Fix building with clang


From: Darren Kenny
Subject: [PATCH 0/2] Fix building with clang
Date: Fri, 14 Oct 2022 15:41:10 +0000

The abiltiy to build with clang was broken in the last release after the
upgrade of gnulib.

There were two main issues:

- The use of __builtin_trap in the abort() macro.

  This builtin doesn't exist for clang builds

  After some discussion between Daniel and Vladimir, it was requested that I
  should revert some past changes in this area, and re-introduce the use of
  grub_abort().

- The is some use of variable length arrays (vla) in gnulib's code, and when
  an attempt was made to resolve this in gnulib itself, I was informed that we
  shouldn't be building gnulib with -Werror.

  Rather than totally disabling -Werror, it seemed better to just limit it for
  the specific case that is causing problems, i.e. vla.

Thanks,

Darren.

Darren Kenny (2):
  gnulib: Provide abort() implementation for gnulib
  configure: Fix building with clang

 config.h.in                       | 10 ----------
 configure.ac                      |  4 ++++
 grub-core/kern/misc.c             |  2 +-
 grub-core/lib/posix_wrap/stdlib.h |  6 ++++++
 include/grub/misc.h               |  5 +----
 5 files changed, 12 insertions(+), 15 deletions(-)

-- 
2.31.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]