Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars

[Olaf Hering]

Tue, 18 Oct 2022 21:53:32 -0700 Denton Liu <liu.denton@gmail.com>:

> On Tue, Oct 18, 2022 at 04:18:21PM +0200, Olaf Hering wrote:
> > Maybe the patch description lacks a specific example how the proposed 
> > change is supposed to be used in your environment.  
> My patch description says:
>       Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and
>       GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the
>       top-level entry.
> and I'm not quite sure how to make it more clear other than, perhaps,
> explaining what the top-level entry means.

After reading the patch again, the newly added documentation states:
"This option should be a path to a kernel image."

I think it needs to be more specific: is it expecting an absolute path, or just 
the basename of the desired image?


Olaf

pgpaxDTB2jSsY.pgp
Description: Digitale Signatur von OpenPGP