[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/1] Add support for grub-emu to kexec Linux menu entries
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v5 1/1] Add support for grub-emu to kexec Linux menu entries |
|
Date: |
Fri, 21 Oct 2022 14:05:25 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Oct 20, 2022 at 03:20:58PM -0400, Robbie Harwood wrote:
> Daniel Kiper <dkiper@net-space.pl> writes:
>
> > On Wed, Oct 19, 2022 at 02:50:00PM -0400, Robbie Harwood wrote:
> >
> >> diff --git a/grub-core/kern/emu/misc.c b/grub-core/kern/emu/misc.c
> >> index d0e7a107e7..521220b49d 100644
> >> --- a/grub-core/kern/emu/misc.c
> >> +++ b/grub-core/kern/emu/misc.c
> >> @@ -39,6 +39,7 @@
> >> #include <grub/emu/misc.h>
> >>
> >> int verbosity;
> >> +int kexecute;
> >
> > We have bool type now so I would use it here. Or at least try it does
> > not break other builds... :-)
>
> As written, it's not actually a boolean... it keeps track of how many
> times the flag has been passed, and that's how the "pass twice" behavior
> is implemented.
Ugh... Sorry, somehow I completely forgot about that thing.
Please ignore this comment then.
Daniel