[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] kern/file: Fix error handling in grub_file_open()

From: Steve McIntyre
Subject: [PATCH] kern/file: Fix error handling in grub_file_open()
Date: Tue, 6 Dec 2022 01:45:11 +0000

grub_file_open() calls grub_file_get_device_name(), but doesn't check
the return. Instead, it checks if grub_errno is set.

However, nothing initialises grub_errno here when grub_file_open()
starts. This means that trying to open one file that doesn't exist and
then trying to open another file that does will (incorrectly) also
fail to open that second file.

Let's fix that.

Signed-off-by: Steve McIntyre <>
 grub-core/kern/file.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/grub-core/kern/file.c b/grub-core/kern/file.c
index 8d48fd50d..668b149c3 100644
--- a/grub-core/kern/file.c
+++ b/grub-core/kern/file.c
@@ -66,6 +66,9 @@ grub_file_open (const char *name, enum grub_file_type type)
   const char *file_name;
   grub_file_filter_id_t filter;
+  /* Reset grub_errno before we start */
+  grub_errno = GRUB_ERR_NONE;
   device_name = grub_file_get_device_name (name);
   if (grub_errno)
     goto fail;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]