grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH V3 4/4] bash-completion:disable shellcheck SC2120-Warning


From: t . feng
Subject: [PATCH V3 4/4] bash-completion:disable shellcheck SC2120-Warning
Date: Tue, 6 Dec 2022 21:49:31 +0800

SC2120 (warning): function references arguments, but none are ever
passed.

In grub-completion.bash.in line 63:
__grub_get_options_from_help () {
^-- SC2120 (warning)
     local prog

     if [ $# -ge 1 ]; then
         prog="$1"

The arg of __grub_get_options_from_help is optional, so the current code
meets the exception and does not need to be modified. Ignoring it.

More: https://github.com/koalaman/shellcheck/wiki/SC2120

Signed-off-by: "t.feng" <fengtao40@huawei.com>
---
 util/bash-completion.d/grub-completion.bash.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/bash-completion.d/grub-completion.bash.in 
b/util/bash-completion.d/grub-completion.bash.in
index a85f18f05..213ce1e57 100644
--- a/util/bash-completion.d/grub-completion.bash.in
+++ b/util/bash-completion.d/grub-completion.bash.in
@@ -63,6 +63,7 @@ __grubcomp () {
 
 # Function that return long options from the help of the command
 # - arg: $1 (optional) command to get the long options from
+# shellcheck disable=SC2120
 __grub_get_options_from_help () {
      local prog
 
-- 
2.27.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]