[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3 0/4] bash-completion:fix shellcheck error and warning
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH V3 0/4] bash-completion:fix shellcheck error and warning |
|
Date: |
Tue, 6 Dec 2022 16:29:34 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Dec 06, 2022 at 09:49:27PM +0800, t.feng via Grub-devel wrote:
> Hi,
> The patch set fix some warning and error in grub-completion.bash.in.
> And shellcheck also provides 'info' and 'style' level check, i think
> grub do not need to modify.
>
> shellcheck -s bash -S warning grub-completion.bash.in
>
> shellcheck:https://github.com/koalaman/shellcheck
>
> V3:
> change functions variables as local
>
> V2:
> split warnings patches
> fix error '"'
>
> ************************
>
> t.feng (4):
> bash-completion:fix shellcheck error
> bash-completion:fix shellcheck SC2207-Warning
> bash-completion:fix shellcheck SC2155-Warning
> bash-completion:disable shellcheck SC2120-Warning
For all patches Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...
Daniel