[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/6] ieee1275: drop len -= 1 quirk in heap_init
|
From: |
Vladimir 'phcoder' Serbinenko |
|
Subject: |
Re: [PATCH v2 2/6] ieee1275: drop len -= 1 quirk in heap_init |
|
Date: |
Tue, 13 Dec 2022 17:07:42 +0100 |
What problem are you trying to solve? Is losing 32 bytes a problem?
On Thu, Dec 1, 2022 at 10:13 PM Stefan Berger <stefanb@linux.ibm.com> wrote:
>
> From: Daniel Axtens <dja@axtens.net>
>
> This was apparently 'required by some firmware': commit dc9468500919
> ("2007-02-12 Hollis Blanchard <hollis@penguinppc.org>").
>
> It's not clear what firmware that was, and what platform from 14 years ago
> which exhibited the bug then is still both in use and buggy now.
>
> It doesn't cause issues on qemu (mac99 or pseries) or under PFW for Power8.
>
> I don't have access to old Mac hardware, but if anyone feels especially
> strongly we can put it under some feature flag. I really want to disable
> it under pseries because it will mess with region merging.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> ---
> grub-core/kern/ieee1275/init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c
> index 0bc571e3e..bb234b268 100644
> --- a/grub-core/kern/ieee1275/init.c
> +++ b/grub-core/kern/ieee1275/init.c
> @@ -166,7 +166,6 @@ heap_init (grub_uint64_t addr, grub_uint64_t len,
> grub_memory_type_t type,
> addr = 0x180000;
> }
> }
> - len -= 1; /* Required for some firmware. */
>
> /* Never exceed HEAP_MAX_SIZE */
> if (*total + len > HEAP_MAX_SIZE)
> --
> 2.25.1
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'phcoder' Serbinenko