Re: [PATCH v4 13/15] gdb: Add extra early initialization symbols for i386-pc

[Glenn Washburn]

On Wed, 21 Dec 2022 16:28:35 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:

> On Thu, Dec 15, 2022 at 11:29:36PM -0600, Glenn Washburn wrote:
> > Add symbols for boot.image, disk.image, and lzma_decompress.image
> > if the target is i386-pc.
> 
> Why?

Why not? I'm not clear on what your objection is. This is for debugging
the code that has those symbols, eg. to break on those symbols.

Glenn

> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  grub-core/gdb_grub.in | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in
> > index 3b3cea1a4d..a9c9d00430 100644
> > --- a/grub-core/gdb_grub.in
> > +++ b/grub-core/gdb_grub.in
> > @@ -181,12 +181,18 @@ set confirm off
> >  # fail.
> >
> >  set $platform_efi = $_streq("@platform@", "efi")
> > +set $target = "@target_cpu@-@platform@"
> >
> >  if ! $runonce
> >     if $platform_efi
> >             # Only load the executable file, not the symbols
> >             exec-file kernel.exec
> >     else
> > +           if $_streq($target, "i386-pc")
> > +                   add-symbol-file boot.image
> > +                   add-symbol-file diskboot.image
> > +                   add-symbol-file lzma_decompress.image
> > +           end
> >             file kernel.exec
> >             run_on_start
> >             runtime_load_module
> 
> Daniel