grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] serial: Cleanup & fix port discovery


From: Daniel Kiper
Subject: Re: [PATCH 0/3] serial: Cleanup & fix port discovery
Date: Thu, 12 Jan 2023 14:01:04 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Dec 23, 2022 at 12:48:46PM +1100, Benjamin Herrenschmidt wrote:
> This series cleans up a few things in serial port discovery
> and fixes detection of duplicates in some cases:
>
>  - Existing usage of memcmp to compare strings is replaces
>    with strncmp
>
>  - Don't lookup ports by name right after creating them,
>    just return the pointer instead.
>
>  - Move the detection of duplicates *into* the various port
>    creation functions. At this point, the various attributes
>    such as port number and address have been properly parsed
>    and there is no confusion between things like wether a
>    0x prefix is present or not for example, or wether hex
>    digits are upper or lower case.

For all the patches Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...

Thank you for fixing the issues!

Daniel

PS I will add missing SOB on your behalf to the last patch. I hope this
   is not big deal...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]