Re: [PATCH 0/3] Allow easy re-running of grub-shell from failed tests

[Daniel Kiper]

On Sat, Jan 21, 2023 at 12:10:43AM -0600, Glenn Washburn wrote:
> When a non-native (eg. grub-shell/qemu) test fails it can be useful to be
> able to re-run the grub-shell invocation in at least two circumstances.
>
> 1. The tester wants to re-run the grub-shell invocation with extra args so
>    that QEMU starts in GDB attach mode for using GDB to debug the test case
> 2. For a tester who wants to send a failed test case to another developer for
>    additional debugging. It would be nice to be able to just zip/tar just
>    the failed test case test output directory and allow the extracted
>    directory to easily run the failed test case again. The results in this
>    case still might not be the same if the sender and reciever do not have
>    the same QEMU. Though when the QMEU versions are different, I expect the
>    emulated execution on sender and reciever to be close enough to produce
>    the same execution path (maybe not with super old QEMUs, but I don't think
>    its something to be concerned about).
>
> The first patch is needed to make the other two useful. Without it, I know of
> no easy way to enable grub-shell's debug mode when run via `make check`. And
> if grub-shell is not in debug mode then it will remove most/all of the
> generated files, which would prevent debugging.
>
> Glenn
>
> Glenn Washburn (3):
>   tests: Allow turning on shell tracing from environment variables
>   grub-shell: Create run.sh in working directory for easily running test
>     again
>   grub-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial
>     QEMU arguments

For all the patches Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...

Daniel