Re: [PATCH v3 4/6] ieee1275: implement vec5 for cas negotiation

[Robbie Harwood]

Stefan Berger <stefanb@linux.ibm.com> writes:

> +    .vec5_size = 1 + sizeof (struct option_vector5) - 2,
> +    .vec5 = {
> +      0, 0, 0, 0, 0, 0, 0, 0, 256
> +    }

Hi Stefan and Diego, are you able to speak to vec5 setting?

I have been talking with Avnish Chouhan (CC'd) downstream and requested
they sync with you, but this patch doesn't seem to have their changes.

They have proposed two different changes.  The first, which I'm
currently carrying, is
https://github.com/rhboot/grub2/commit/c2e640266247e3e0d3268f5ef20a734f5800f577
which sets

    .vec5 = { -1, -1, -1, -1, -1, -1, -1, -1, 256 }

while the latest proposal is
https://gist.github.com/frozencemetery/b36d8ee9b6282645fac52bf5a010b439
which sets

    .vec5 = { 0, 192, 0, 128, 0, 0, 0, 0, 256 }

Obviously I can't ship all three at once.  As I'm not an expert on cas,
could you all please unify this into a single suggestion we can ship
upstream and down?

(If it helps, I believe these are IBM bugs
https://bugzilla.linux.ibm.com/show_bug.cgi?id=200825 and
https://bugzilla.linux.ibm.com/show_bug.cgi?id=200213 )

Be well,
--Robbie

signature.asc
Description: PGP signature