grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] net/bootp: Fix unchecked return value


From: Alec Brown
Subject: [PATCH] net/bootp: Fix unchecked return value
Date: Fri, 3 Feb 2023 17:18:14 -0500

In the function send_dhcp_packet(), added an error check for the return value of
grub_netbuff_push().

Fixes: CID 404614

Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
 grub-core/net/bootp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/grub-core/net/bootp.c b/grub-core/net/bootp.c
index 7d31dba97..abe45ef7b 100644
--- a/grub-core/net/bootp.c
+++ b/grub-core/net/bootp.c
@@ -583,7 +583,9 @@ send_dhcp_packet (struct grub_net_network_level_interface 
*iface)
 
   grub_memcpy (&pack->mac_addr, &iface->hwaddress.mac, 6);
 
-  grub_netbuff_push (nb, sizeof (*udph));
+  err = grub_netbuff_push (nb, sizeof (*udph));
+  if (err)
+    goto out;
 
   udph = (struct udphdr *) nb->data;
   udph->src = grub_cpu_to_be16_compile_time (68);
-- 
2.27.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]