[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: Add pathological iso9660 filesystem tests
|
From: |
Glenn Washburn |
|
Subject: |
Re: [PATCH] tests: Add pathological iso9660 filesystem tests |
|
Date: |
Mon, 6 Feb 2023 10:46:35 -0600 |
On Sun, 05 Feb 2023 09:24:21 +0100
"Thomas Schmitt" <scdbackup@gmx.net> wrote:
> Hi,
>
> Glenn Washburn wrote:
> > --- a/tests/iso9660_test.in
> > +++ b/tests/iso9660_test.in
> > @@ -12,4 +12,13 @@ fi
> > "@builddir@/grub-fs-tester" rockridge_joliet
> > "@builddir@/grub-fs-tester" joliet_1999
> > "@builddir@/grub-fs-tester" rockridge_1999
> > -"@builddir@/grub-fs-tester" rockridge_joliet_1999
> > \ No newline at end of file
> > +"@builddir@/grub-fs-tester" rockridge_joliet_1999
> > +
> > +for fs in iso9660_ce_loop iso9660_ce_loop2; do
> > + tempdir=`mktemp -d "${TMPDIR:-/tmp}/${0##*/}.$(date
> > '+%Y%m%d%H%M%S%N').${fs}.XXX"` ||
> > + { echo "Failed to make temporary directory"; exit 99; }
> > + gunzip <"$srcdir"/tests/${fs}.iso.gz >"${tempdir}/${fs}.iso"
> > + output=$(LC_ALL=C timeout -s KILL "60" \
> > + "@builddir@/grub-fstest" "${tempdir}/${fs}.iso" ls / )
> > + test "$?" -eq 0 -a -z "$output"
> > +done
>
> Shouldn't the decompressed files and the temporary directory be
> removed afterwards ?
Yes, good catch. I'll update.
Glenn