Re: [PATCH v3] tests: Add pathological iso9660 filesystem tests

[Glenn Washburn]

On Thu, 16 Feb 2023 19:36:40 +0100
"Thomas Schmitt" <scdbackup@gmx.net> wrote:

> Hi,
> 
> Glenn Washburn wrote:
> > > > +echo "Testing for proper recognition of CE loops ... "
> > Ugh, this should be "echo -n".
> 
> My make "check" wrote:
> > >   Testing for proper recognition of CE loops ...
> > >   FAIL (iso9660_ce_loop)
> > >   FAIL iso9660_test (exit status: 1)
> 
> Actually this looks quite ok to me.
> 
> With
>   echo -n "Testing for proper recognition of CE loops ... "
> and a disabled loop breaker i get in test-suite.log:
> 
>   Testing for proper recognition of CE loops ... FAIL
> (iso9660_ce_loop) FAIL iso9660_test (exit status: 1)
> 
> which looks to me like a newline is missing.
> 
> 
> The combination of "echo -n" and "..." seems not to occur in the GRUB
> code: $ grep -r 'echo -n .*\.\.\.' . | less
> 
> Some echo without -n have "...":
>   $ grep -r 'echo .*\.\.\.' . | wc -l
>   65
>   $ grep -r 'echo .*\.\.\.' tests
>   tests/partmap_test.in:echo "Checking MSDOS partition types..."
>   tests/partmap_test.in:echo "Checking GPT partition types..."
>   tests/partmap_test.in:echo "Checking SUN partition types..."
>   tests/partmap_test.in:echo "Checking APPLE partition types..."
>   tests/partmap_test.in:echo "Checking DVH partition types..."
>   tests/partmap_test.in:echo "Checking AMIGA partition types..."
>   tests/partmap_test.in:echo "Checking DragonFly BSD disklabel64..."
>   $
> 
> If "..." as line end is too near to ./configure style, then how about
> 
>   echo "Testing for proper recognition of CE loops:"

I think the without the new line looks better to me, but it is more
consistent with partmap_test as it is now (and less consistent with
grub_cmd_cryptomount). Either way it does what it needs to do and is
easy enough for a person who needs to look into it to understand. So
I'll leave it as is and see if Daniel has any suggestions. Thanks for
surveying the code to see what makes sense in terms of consistency.

Glenn