In general series looks good. Few comments:
* I'm unsure about the name. It seems to suggest that people put the dependencies there by default while in fact it's the last place for it. Maybe extra_deps.lst?
* EFI supports both GPT and msdos. GPT is a more common choice but I still think that a dependency on part_msdos is warranted
* Please elaborate commit message as to why bli needs those mods rather than "not functions properly". Detail that it needs to identify partitions.
The bli module has a hidden/implicit dependency on the part_gpt module.
The part_gpt module has to be loaded before the bli module.
This dependency is not picked up automatically by the build system
because the bli module does not use any function of part_gpt. It just
expects Grub to be able to parse GPT formatted disks.
This series introduces a mechanism that allows specifying module
dependencies explicitly in a new file called explicit_dependencies.lst.
An explicit dependency is then added for the bli module on the part_gpt
module.
Oliver Steffen (2):
Allow explicit module dependencies
bli: Add explicit dependency on the part_gpt module
grub-core/Makefile.am | 4 ++--
grub-core/explicit_dependencies.lst | 1 +
grub-core/genmoddep.awk | 4 ++++
3 files changed, 7 insertions(+), 2 deletions(-)
create mode 100644 grub-core/explicit_dependencies.lst
--
2.41.0