Re: [RFC PATCH] Track explicit module dependencies in Makefile.core.def

[Oskari Pirhonen]

On Thu, Feb 22, 2024 at 14:32:31 +0100, Oliver Steffen wrote:
> Add a new keyword, "depends", to the module definition syntax
> used in Makefile.core.def. This allows specifying explicit module
> dependencies together with the module definition.
> 
> Do not track the "extra_deps.lst" file in the repository anymore,
> it is now auto-generated.
> 

Trying to build with this, it looks like it might be broken at the site
where the extra_deps.lst is used:

1. Apply this patch in a fresh git tree
2. Revert "build: Include grub-core/extra_deps.lst in dist" (after all,
   no need to include it if it's auto generated, right?)
3. Create a dist tarball

    $ ./bootstrap
    $ mkdir compile
    $ cd compile
    $ ../configure
    $ make dist

4. Unpack tarball (eg, into /tmp)
5. Try to build from the tarball

    $ cd /tmp/grub
    $ mkdir compile
    $ cd compile
    $ ../configure --with-platform=efi
    $ make
    ...
    cat kernel_syms.lst ../../grub-core/extra_deps.lst > syminfo.lst.new
    cat: ../../grub-core/extra_deps.lst: No such file or directory
    make[3]: *** [Makefile:51281: syminfo.lst] Error 1
    make[3]: Leaving directory '/tmp/grub-2.13/compile/grub-core'
    make[2]: *** [Makefile:28866: all] Error 2
    make[2]: Leaving directory '/tmp/grub-2.13/compile/grub-core'
    make[1]: *** [Makefile:12131: all-recursive] Error 1
    make[1]: Leaving directory '/tmp/grub-2.13/compile'
    make: *** [Makefile:3958: all] Error 2

The file with the correct contents does get generated into grub-core/,
but if I'm understanding the output correctly, it's trying to grab
extra_deps.lst from outside the compile/ subdirectory.

- Oskari

> Make use of this new keyword in the bli module definition.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>

signature.asc
Description: PGP signature