[Guile-commits] 02/02: Fix peval bug when expand-primitives introduces lexicals

[Andy Wingo]

wingo pushed a commit to branch main
in repository guile.

commit ff7328df0d881f9d13f5aaed8eb16997d82bb884
Author: Andy Wingo <wingo@pobox.com>
AuthorDate: Thu Dec 1 13:00:18 2022 +0100

    Fix peval bug when expand-primitives introduces lexicals
    
    * module/language/tree-il/peval.scm
    (augment-var-table-with-externally-introduced-lexicals): New helper.
    * module/language/tree-il/peval.scm (peval): Augment store with any
    lexicals introduced by expand-primitives.
    * test-suite/tests/peval.test ("partial evaluation"): Add tests.
---
 module/language/tree-il/peval.scm | 40 +++++++++++++++++++++++++++++++++++++--
 test-suite/tests/peval.test       | 10 +++++++++-
 2 files changed, 47 insertions(+), 3 deletions(-)

diff --git a/module/language/tree-il/peval.scm 
b/module/language/tree-il/peval.scm
index e2d98f946..7945fd9b9 100644
--- a/module/language/tree-il/peval.scm
+++ b/module/language/tree-il/peval.scm
@@ -158,6 +158,39 @@
    (lambda (exp res) res)
    table exp))
 
+(define (augment-var-table-with-externally-introduced-lexicals exp table)
+  "Take the previously computed var table TABLE and the term EXP and
+return a table augmented with the lexicals bound in EXP which are not
+present in TABLE.  This is used for the result of `expand-primcalls`,
+which may introduce new lexicals if a subexpression needs to be
+referenced multiple times."
+  (define (maybe-add-var name sym table)
+    ;; Use a refcount of 2 to prevent the copy-single optimization.
+    (define refcount 2)
+    (define assigned? #f)
+    (if (vhash-assq sym table)
+        table
+        (vhash-consq sym (make-var name sym refcount assigned?) table)))
+  (tree-il-fold
+   (lambda (exp table)
+     (match exp
+       (($ <lambda-case> src req opt rest kw init gensyms body alt)
+        (fold maybe-add-var table
+              (append req (or opt '()) (if rest (list rest) '())
+                      (match kw
+                        ((aok? (kw name sym) ...) name)
+                        (_ '())))
+              gensyms))
+       (($ <let> src names gensyms vals body)
+        (fold maybe-add-var table names gensyms))
+       (($ <letrec>)
+        (error "unexpected letrec"))
+       (($ <fix> src names gensyms vals body)
+        (fold maybe-add-var table names gensyms))
+       (_ table)))
+   (lambda (exp table) table)
+   table exp))
+
 ;; Counters are data structures used to limit the effort that peval
 ;; spends on particular inlining attempts.  Each call site in the source
 ;; program is allocated some amount of effort.  If peval exceeds the
@@ -1493,8 +1526,11 @@ top-level bindings from ENV and return the resulting 
expression."
        (let revisit-proc ((proc (visit orig-proc 'operator)))
          (match proc
            (($ <primitive-ref> _ name)
-            (for-tail
-             (expand-primcall (make-primcall src name orig-args))))
+            (let ((exp (expand-primcall (make-primcall src name orig-args))))
+              (set! store
+                    (augment-var-table-with-externally-introduced-lexicals
+                     exp store))
+              (for-tail exp)))
            (($ <lambda> _ _
                ($ <lambda-case> _ req opt rest #f inits gensyms body #f))
             ;; Simple case: no keyword arguments.
diff --git a/test-suite/tests/peval.test b/test-suite/tests/peval.test
index 76fa271fd..89b4870f6 100644
--- a/test-suite/tests/peval.test
+++ b/test-suite/tests/peval.test
@@ -1,7 +1,7 @@
 ;;;; tree-il.test --- test suite for compiling tree-il   -*- scheme -*-
 ;;;; Andy Wingo <wingo@pobox.com> --- May 2009
 ;;;;
-;;;;   Copyright (C) 2009-2014, 2017, 2020 Free Software Foundation, Inc.
+;;;;   Copyright (C) 2009-2014, 2017, 2020, 2022 Free Software Foundation, Inc.
 ;;;;
 ;;;; This library is free software; you can redistribute it and/or
 ;;;; modify it under the terms of the GNU Lesser General Public
@@ -1349,6 +1349,14 @@
     (apply (lambda (x y) (cons x y)) (list 1 2))
     (primcall cons (const 1) (const 2)))
 
+  (pass-if-peval
+    (apply = (list 0 0 0))
+    (const #t))
+
+  (pass-if-peval
+    (apply char<? (list #\a #\b #\c))
+    (const #t))
+
   ;; Disable after removal of abort-in-tail-position optimization, in
   ;; hopes that CPS does a uniformly better job.
   #;