[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] CVS-Guile dump.c compilation problems
From: |
Keisuke Nishida |
Subject: |
Re: [Patch] CVS-Guile dump.c compilation problems |
Date: |
Thu, 15 Feb 2001 20:05:42 -0500 |
User-agent: |
Wanderlust/2.4.0 (Rio) SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.0.96 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Thu, 15 Feb 2001 22:54:01 +0100 (MET),
Dirk Herrmann wrote:
>
> On 15 Feb 2001, Matthias Koeppe wrote:
>
> > I compile Guile with the Sun Workshop 6 update 1 ("Forte") compiler.
> > The compiler complains about code in `scm_undump', where you try to
> > take the address of SCM_CDR(obj) and SCM_CAR(obj). This is probably
> > not a good idea because SCM_CDR(obj) is not guaranteed to be an
> > lvalue. Another issue was a signed/unsigned discrepancy.
> >
> > A patch is attached below.
>
> IMO, a better solution would be to use SCM_C[AD]RLOC, which is defined in
> gc.h.
At 15 Feb 2001 12:29:41 +0100,
Matthias Koeppe wrote:
>
> @@ -467,7 +471,7 @@
> {
> case scm_tc7_symbol:
> {
> - int len;
> + scm_sizet len;
> const char *mem;
> scm_restore_string (&mem, &len, dstate);
> obj = scm_mem2symbol (mem, len);
> @@ -475,7 +479,7 @@
> }
> case scm_tc7_string:
> {
> - int len;
> + scm_sizet len;
> const char *mem;
> scm_restore_string (&mem, &len, dstate);
> obj = scm_makfromstr (mem, len, 0);
I have applied these changes. Thanks.
Kei