guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Proposed change to `make-readline-port'


From: Dirk Herrmann
Subject: Re: Proposed change to `make-readline-port'
Date: Tue, 6 Mar 2001 01:46:49 +0100 (MET)

A little improvement:  If you replace the line

  (set! (buffered-input-continuation? port) #t)

by

  (if (not (char-whitespace? res))
      (set! (buffered-input-continuation? port) #t))

then the following will work:  Enter a space on after the prompt and type
return.  In the previous version and in your current one the prompt will
change to '...', after applying the above change it won't.

However, the implementation of buffered-input has a lot of hard-coded
knowledge to realize the 'continuation?' trick, which makes it less
generally useful than was originally intended.  Thus I wonder if it is
really a good change after all...

Best regards,
Dirk Herrmann




reply via email to

[Prev in Thread] Current Thread [Next in Thread]