guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: srfi-19 date-week-number gremlin


From: Marius Vollmer
Subject: Re: srfi-19 date-week-number gremlin
Date: Sun, 05 Oct 2003 17:24:53 +0200
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)

Kevin Ryde <address@hidden> writes:

> I noticed srfi-19 date-week-number seems to be off by 1 in its week
> start calculation.  For instance looking at Jan 1984, Sat 7th should
> be in the first week and Sun 8th begin the next, but alas,
>
>       (date-week-number (make-date 0 0 0 0 7 1 1984 0) 0)
>       (date-week-number (make-date 0 0 0 0 8 1 1984 0) 0)
>
> both give 1.
>
> The code looks about right, just doesn't take into account
> date-year-day starting from 1 rather than 0.
>
>         * srfi-19.scm (date-week-number): Correction, day of week starting
>         week was off by one.
>
>         * tests/srfi-19.test (date-week-number): Add tests.
>
> I think this could go in the 1.6 branch too.

Yes, please.

-- 
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3  331E FAF8 226A D5D4 E405




reply via email to

[Prev in Thread] Current Thread [Next in Thread]