guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Strange code in modules.c


From: Dirk Herrmann
Subject: Strange code in modules.c
Date: Sat, 22 Nov 2003 00:16:51 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312

Hi Folks,

the following patch fixes a piece of code in modules.c which seems wrong to me. I am, however, not quite sure that I am not missing something. If there are no complaints I will submit the patch in the next couple of days.

RCS file: /cvsroot/guile/guile/guile-core/libguile/modules.c,v
retrieving revision 1.51
diff -u -r1.51 modules.c
--- libguile/modules.c  12 Sep 2003 15:11:09 -0000      1.51
+++ libguile/modules.c  21 Nov 2003 22:27:29 -0000
@@ -277,8 +277,7 @@
module_variable (SCM module, SCM sym)
{
#define SCM_BOUND_THING_P(b) \
-  (!SCM_FALSEP(b) && \
-   (!SCM_VARIABLEP(b) || !SCM_UNBNDP (SCM_VARIABLE_REF (b))))
+  (SCM_VARIABLEP (b) && !SCM_UNBNDP (SCM_VARIABLE_REF (b)))

  /* 1. Check module obarray */
  SCM b = scm_hashq_ref (SCM_MODULE_OBARRAY (module), sym, SCM_UNDEFINED);

Best regards
Dirk





reply via email to

[Prev in Thread] Current Thread [Next in Thread]