[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: i guess we're frozen & stuff
From: |
Mike Gran |
Subject: |
Re: i guess we're frozen & stuff |
Date: |
Tue, 11 Aug 2009 11:01:39 -0700 (PDT) |
> From: Juhani Viheräkoski address@hidden
> Hi,
>
> For me the build of the current master fails with:
>
> libtool: compile: gcc -DHAVE_CONFIG_H -DBUILDING_LIBGUILE=1 -I.. -I..
-I../lib
> -I../lib -pthread -Wall -Wmissing-prototypes -Werror -fvisibility=hidden -O3
-g
> -march=athlon-xp -MT libguile_la-strings.lo -MD -MP -MF
> .deps/libguile_la-strings.Tpo -c strings.c -fPIC -DPIC -o
> .libs/libguile_la-strings.o
> cc1: warnings being treated as errors
> strings.c: In function ‘scm_string_append’:
> strings.c:1300: error: ‘data’ may be used uninitialized in this function
> make[3]: *** [libguile_la-strings.lo] Error 1
>
> It is easy to disable -Werror or set the offending variable to NULL, but with
my
> limited knowledge of Guile internals it seems that this uninitialized pointer
is
> indeed passed to scm_i_make_string or scm_i_make_wide_string which do not
> seem
> to reserve space for it and even dereference the pointer. Might be just me,
but
> it seems there is something weird going on here..
>
This one's okay, I think. The allocation is made in make_stringbuf and `data'
is set to point to its buffer.
We'll have to set it to NULL in scm_string_append and other places to quiet
warnings.
> -- Juhani
Thanks,
-Mike
Re: i guess we're frozen & stuff, Mike Gran, 2009/08/11
Re: i guess we're frozen & stuff, Juhani Viheräkoski, 2009/08/11
Re: i guess we're frozen & stuff, Greg Troxel, 2009/08/11
unsigned char confusion, Greg Troxel, 2009/08/11
Re: i guess we're frozen & stuff, Ken Raeburn, 2009/08/11