[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: `SCM_MAKE_CHAR ()' signedness issue
From: |
Mike Gran |
Subject: |
Re: `SCM_MAKE_CHAR ()' signedness issue |
Date: |
Tue, 18 Aug 2009 10:32:29 -0700 (PDT) |
> From: Ludovic Courtès <address@hidden>
> To: address@hidden
> Sent: Monday, August 17, 2009 8:33:03 AM
> Subject: Re: `SCM_MAKE_CHAR ()' signedness issue
>
> I'm fairly confident that for such a small piece of code inlining is
> always a good idea.
OK. If the comparison is modified to become
35 #define SCM_MAKE_CHAR(x) \
36 (((x) < 128) \
37 ? SCM_MAKE_ITAG8 ((scm_t_bits) (unsigned char) (x), scm_tc8_char) \
38 : SCM_MAKE_ITAG8 ((scm_t_bits) (x), scm_tc8_char))
Then hopefully that will solve all the build problems.
> Thanks,
> Ludo'.
-Mike