[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] %nil-handling optimization and fixes v1
From: |
Neil Jerram |
Subject: |
Re: [PATCH] %nil-handling optimization and fixes v1 |
Date: |
Sun, 30 Aug 2009 10:18:04 +0100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) |
Andy Wingo <address@hidden> writes:
>> scm_is_false_assume_not_lisp_nil scm_is_true_assume_not_lisp_nil
>> scm_is_false_and_not_lisp_nil scm_is_true_or_lisp_nil
>> scm_is_false_or_lisp_nil scm_is_true_and_not_lisp_nil
>>
>> scm_is_lisp_false scm_is_lisp_true
>>
>> scm_is_null_assume_not_lisp_nil
>> scm_is_null_and_not_lisp_nil
>> scm_is_null_or_lisp_nil
>>
>> scm_is_bool_and_not_lisp_nil
>> scm_is_bool_or_lisp_nil
>
> These are terrible names. But they seem to be the best names for the
> concepts we're trying to express. I don't understand all of them yet,
> will wait for a review -- unless Neil takes care of that before I do ;-)
I actually feel quite comfortable with them, now that I've read the
patch carefully. Mark's comments above the macro definitions seem
helpful and sufficient to me.
Regards,
Neil