[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.7-29-ge2
From: |
Ludovic Courtès |
Subject: |
Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.7-29-ge211d69 |
Date: |
Wed, 16 Jan 2013 16:54:17 +0100 |
User-agent: |
Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) |
"Andy Wingo" <address@hidden> skribis:
> fix string->bytevector for utf-8 and non-error conversion strategies
>
> * module/ice-9/iconv.scm (call-with-encoded-output-string):
> (string->bytevector, bytevector->string): Only call string->utf8 and
> utf8->string if the conversion strategy is `error'.
string->bytevector cannot fail when the encoding is UTF-8.
As for bytevector->string, you should compare against
(%default-port-conversion-strategy) rather than 'error, I think.
Would be nice to have tests for these corner cases.
Ludo’.
- Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.7-29-ge211d69,
Ludovic Courtès <=