[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: write-request-line empty path bug
From: |
Mark H Weaver |
Subject: |
Re: write-request-line empty path bug |
Date: |
Mon, 19 Aug 2013 00:24:08 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Hi Ian,
Ian Price <address@hidden> writes:
> When you make a http request in guile where the URL has an empty path
> and a non-empty query string, write-request-line fails to write the
> /. This bit me just a few hours ago.
>
> From the RFC:
>
> If the abs_path is not present in the URL, it MUST be given as "/" when
> used as a Request-URI for a resource (section 5.1.2).
>
> The code as written will not write it if a query is added, but this is
> incorrect as far as the wording goes, because the query is not a part of
> the abs_path.
>
> This patch corrects this.
Looks good to me. Please push!
> Hopefully it will mark the beginning of my glorious return to Guile
> after some time apart :)
I hope so too :)
Thanks,
Mark