guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add GNU-style error location for failing tests in test-suite


From: Mark H Weaver
Subject: Re: [PATCH] Add GNU-style error location for failing tests in test-suite. v3
Date: Wed, 29 Oct 2014 17:40:20 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Hi Jan,

Jan Nieuwenhuizen <address@hidden> writes:
>
> Changes in v3:
>
>   * fix source-line/user-source-line confusion in srfi-64
>   * better conforming commit message

Did you try running "make check" with this patch applied?  I found
that there were well over a hundred other uses of 'run-test' in the
test-suite directory that you didn't update.

Also, can you try to keep lines to 80 columns max?

     Thanks!
       Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]