Re: freeing fports

[Kevin Ryde]

Aaron VanDevender <address@hidden> writes:
>
> I noticed that the fport free function doesn't return how much
> it frees.

Thanks.

> This patch should take care of that.

No, not quite, I think you need to allow for buffers possibly being
"shortbuf" (size 1), which is not freed.

Probably best to make the adjustment in fport_close, since a port can
be closed before it's freed.  setvbuf looks like it suffers the same
sort of leak.

        * fports.c (scm_setvbuf, fport_close): Call scm_done_free for space
        freed.

Unfortunately this still doesn't make open+close leave scm_mallocated
unchanged, so maybe there's a leak somewhere else too.  Maybe it's not
worth worrying about in the 1.6 branch.  Seems ok in the latest cvs.

fports.c.done_free.diff
Description: Text document