guile-user
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Guile 1.7.1 has been released.


From: Marius Vollmer
Subject: Re: Guile 1.7.1 has been released.
Date: Tue, 21 Sep 2004 00:53:33 +0200
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

Andreas Vögele <address@hidden> writes:

> I've attached a patch that replaces the remaining occurrences of int
> in srfi-13.c with size_t. In addition to these replacements, the
> function string_reverse_x() makes sure that the variable cend is only
> decremented if it's value is greater than zero.

Thanks, applied!

> One thing that I noted is that the variable cfrom in scm_xsubstring()
> and the variable csfrom in scm_string_xcopy_x() are of type size_t but
> that they are checked for negative values:

Yes, I changed them to be ints.  The 'extended' indices can be
negative.  Of course, the could also be bignums...

> BTW, do you prefer included or attached patches?

Either way is fine with me.  For attached patches, using text/plain or
text/x-patch as the content-type makes it simpler to view it.

Also, and more importantly, inculding a ChangeLog entry is very
helpful.

-- 
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3  331E FAF8 226A D5D4 E405




reply via email to

[Prev in Thread] Current Thread [Next in Thread]