guile-user
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: guile.m4


From: Neil Jerram
Subject: Re: guile.m4
Date: Wed, 14 Jun 2006 01:17:36 +0100
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

Aaron VanDevender <address@hidden> writes:

> Here is a slightly improved version of my guile.m4 patch. It has some
> more explicit comments and uses the guile executable set by GUILE_PROGS

Thanks for working on this.  I have a couple of queries.

> +GUILE_CHECK([GUILE_CORRECT_VERSION_P],
> +    [(exit (let loop ((v1 (map string->number (string-split (version) 
> (string-ref \".\" 0))))
> +             (v2 (map string->number (string-split \"$1\" (string-ref \".\" 
> 0)))))

Can we use #\. instead of (string-ref "." 0), or is the former a
nightmare to quote correctly?

> +             (cond ((and (null? v1) (null? v2)) 0)
> +                   ((null? v1) 0)
> +                   ((null? v2) 1)
> +                   ((> (car v1) (car v2)) 0)
> +                   ((< (car v1) (car v2)) 1)

Shouldn't the (null? v1) case have the same polarity as the (< v1 v2)
case (because absence == 0) ?

Regards,
     Neil





reply via email to

[Prev in Thread] Current Thread [Next in Thread]