[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: guile-gdbm doesn't work with gdbm-1.14

From: Mark H Weaver
Subject: Re: guile-gdbm doesn't work with gdbm-1.14
Date: Mon, 19 Mar 2018 12:17:35 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Ricardo Wurmus <address@hidden> writes:

> Mark H Weaver <address@hidden> writes:
>> address@hidden (宋文武) writes:
>>> Hello, since version 1.14, gdbm doesn't export "gdbm_errno" anymore [1],
>>> so the guile-gdbm ffi binding code [2] need updates now (I'm not
>>> confident to do it myself...).
>>> [1] 
>>> [2]
>> Here's a preliminary fix.
> Thank you.
>> * gnu/packages/patches/guile-gdbm-ffi-support-gdbm-1.14.patch: New file.
>> * gnu/ (dist_patch_DATA): Add it.
>> * gnu/packages/guile.scm (guile-gdbm-ffi)[native-inputs]: New field.
>> [inputs]: Move above arguments.  Add the patch, and the 'patch' program.
>> [propagated-inputs]: Move above arguments.
>> [arguments]: In the builder, add code to apply the patch.
> I don’t see the native-inputs field in the patch.

Indeed, sorry for the mistake in the commit log.  Initially I made them
native inputs, but then I moved them to 'inputs'.

> Shouldn’t the “patch” and “patch-file” inputs be native-inputs?

Yes.  However, I noticed that the package already assumes a native
build, because it runs 'guile' from 'inputs' to compile the Scheme code.
Also, I wasn't sure off-hand how native-inputs are handled in the

For purposes of this commit, I didn't want to take on the job of also
fixing this package for cross-building, which I was likely to get wrong
without testing.  Given that I no longer use substitutes, that would
have been a big job.

Does that make sense?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]