[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mmap for guile

From: Greg Troxel
Subject: Re: mmap for guile
Date: Mon, 04 Jul 2022 09:14:17 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (berkeley-unix)

Ludovic Courtès <> writes:

> Besides what Maxime points out, some more superficial issues:
>   • In documentation, please refer to the relevant glibc section instead
>     of “See man page” (info "(libc) Memory-mapped I/O").
>   • Please update doc/ref with a section on memory-mapped I/O.
>   • Make sure to follow the GNU coding in C: space before opening paren,
>     braces on a line of their own, etc.

I have been meaning to try to build this under NetBSD, to check
portability. I think the mmap code should by default rely only on what
POSIX guarantees:

As for referring to glibc, that reference only resolves on GNU/Linux
systems, whereas any POSIX system ought to have an mmap man page, so it
would be nice not to drop the man page ref, esp. as it grounds the
implementation as being about the POSIX interface.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]