83/376: Fix bogus pass by reference

[Ludovic Courtès]

civodul pushed a commit to tag 1.8
in repository guix.

commit aa1560ca079148f5656cbec0d8057d551cb571ff
Author: Eelco Dolstra <address@hidden>
Date:   Thu Jul 24 09:52:10 2014 +0200

    Fix bogus pass by reference
    
    http://hydra.nixos.org/build/12711659
---
 src/libutil/monitor-fd.hh |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/src/libutil/monitor-fd.hh b/src/libutil/monitor-fd.hh
index 2cc495c..6f7f979 100644
--- a/src/libutil/monitor-fd.hh
+++ b/src/libutil/monitor-fd.hh
@@ -15,23 +15,19 @@ class MonitorFdHup
 {
 private:
     std::thread thread;
-    std::atomic_bool quit;
 
 public:
     MonitorFdHup(int fd)
     {
-        quit = false;
-        thread = std::thread([&]() {
+        thread = std::thread([fd]() {
             /* Wait indefinitely until a POLLHUP occurs. */
             struct pollfd fds[1];
             fds[0].fd = fd;
             fds[0].events = 0;
             if (poll(fds, 1, -1) == -1) {
                 if (errno != EINTR) abort(); // can't happen
-                assert(quit);
                 return; // destructor is asking us to exit
             }
-            fprintf(stderr, "GOT: %d\n", fds[0].revents);
             assert(fds[0].revents & POLLHUP);
             /* We got POLLHUP, so send an INT signal to the main thread. */
             kill(getpid(), SIGINT);
@@ -40,7 +36,6 @@ public:
 
     ~MonitorFdHup()
     {
-        quit = true;
         pthread_kill(thread.native_handle(), SIGINT);
         thread.join();
     }