[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
49/197: installer: Replace spawned mount command with the mount syscall.
From: |
Danny Milosavljevic |
Subject: |
49/197: installer: Replace spawned mount command with the mount syscall. |
Date: |
Mon, 3 Jul 2017 20:36:58 -0400 (EDT) |
dannym pushed a commit to branch wip-installer-2
in repository guix.
commit 29da79caa0ad630e777f989caeb1a1125fc9a06c
Author: John Darrington <address@hidden>
Date: Fri Dec 30 09:35:48 2016 +0100
installer: Replace spawned mount command with the mount syscall.
* gnu/system/installer/install.scm (install-page-key-handler): Use the mount
system call, instead of spawning the mount command.
---
gnu/system/installer/install.scm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gnu/system/installer/install.scm b/gnu/system/installer/install.scm
index ceeb960..65e7520 100644
--- a/gnu/system/installer/install.scm
+++ b/gnu/system/installer/install.scm
@@ -27,6 +27,7 @@
#:use-module (ncurses curses)
#:use-module (guix store)
#:use-module (guix utils)
+ #:use-module ((guix build syscalls) #:select (mount umount))
#:use-module (guix build utils)
#:export (make-install-page))
@@ -37,7 +38,6 @@
title
install-page-refresh
install-page-key-handler)))
-
page))
@@ -82,11 +82,10 @@
(lambda ()
(and
(mkdir-p target)
- (zero? (pipe-cmd window-port "mount"
- "mount" "-t" "ext4" root-device target))
+ (mount root-device target "ext4" #:update-mtab? #f)
(zero? (pipe-cmd window-port "herd"
- "herd" "start" "cow-store" target))
+ "herd" "start" "cow-store" target))
(mkdir-p (string-append target "/etc"))
(or (copy-file config-file
@@ -107,8 +106,9 @@
(lambda (key subr message args . rest)
(display-error (stack-ref (make-stack #t) 3)
window-port subr message args rest)))
+
(close-port window-port))))
- #f))
+ #f))
(define (install-page-refresh page)
(when (not (page-initialised? page))
- 59/197: installer: Format configuration to fix width of window., (continued)
- 59/197: installer: Format configuration to fix width of window., Danny Milosavljevic, 2017/07/03
- 65/197: installer: Ensure that all mount points are absolute paths., Danny Milosavljevic, 2017/07/03
- 09/197: installer: Use a record instead of a list to contain tasks., Danny Milosavljevic, 2017/07/03
- 23/197: installer: Use a cleaner way of generating the lspci information., Danny Milosavljevic, 2017/07/03
- 35/197: installer: New predicate valid-hostname?, Danny Milosavljevic, 2017/07/03
- 36/197: installer: Ensure that all mount-points have a file system., Danny Milosavljevic, 2017/07/03
- 39/197: installer: Replace an instance of cdr with match., Danny Milosavljevic, 2017/07/03
- 46/197: installer: Replace "%temporary-configuration-file-port" with "config-file"., Danny Milosavljevic, 2017/07/03
- 30/197: installer: Write the configuration to a temporary file., Danny Milosavljevic, 2017/07/03
- 24/197: installer: Add a new menu to configure wireless interfaces., Danny Milosavljevic, 2017/07/03
- 49/197: installer: Replace spawned mount command with the mount syscall.,
Danny Milosavljevic <=
- 44/197: installer: Use consistent window heights., Danny Milosavljevic, 2017/07/03
- 52/197: installer: Prevent the user specifying the same mount point twice., Danny Milosavljevic, 2017/07/03
- 51/197: installer: Allow users to remove mount points during configuration., Danny Milosavljevic, 2017/07/03
- 14/197: installer: Add procedures to replace car/cdr since these are frounded upon by Guile gurus., Danny Milosavljevic, 2017/07/03
- 55/197: installer: Use global variable instead of string literal for "/gnu"., Danny Milosavljevic, 2017/07/03
- 54/197: installer: Change the order of the filesystem task conditions., Danny Milosavljevic, 2017/07/03
- 60/197: installer: Do not allow forms to set the cursor visibility., Danny Milosavljevic, 2017/07/03
- 56/197: installer: Do not use /tmp for holding the configuration., Danny Milosavljevic, 2017/07/03
- 66/197: installer: Add option to final page to reboot the system., Danny Milosavljevic, 2017/07/03
- 71/197: installer: Add confidence indicator., Danny Milosavljevic, 2017/07/03