02/11: services: certbot: Run certbot twice a day at a random minute.

[Clément Lassieur]

snape pushed a commit to branch master
in repository guix.

commit 7ab04c17c01a926660cd1c9fa9311a5efc6716da
Author: Clément Lassieur <address@hidden>
Date:   Fri Feb 9 01:01:17 2018 +0100

    services: certbot: Run certbot twice a day at a random minute.
    
    * doc/guix.texi (Certificate Services): Document it.
    * gnu/services/certbot.scm (certbot-renewal-jobs): Change job's time
    specification.
---
 doc/guix.texi            | 8 +++++++-
 gnu/services/certbot.scm | 8 ++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index fb28349..03cd2d5 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -30,7 +30,7 @@ Copyright @copyright{} 2016, 2017 address@hidden
 Copyright @copyright{} 2016, 2017 Jan address@hidden
 Copyright @copyright{} 2016 Julien address@hidden
 Copyright @copyright{} 2016 Alex ter address@hidden
-Copyright @copyright{} 2017 Clément address@hidden
+Copyright @copyright{} 2017, 2018 Clément address@hidden
 Copyright @copyright{} 2017 Mathieu address@hidden
 Copyright @copyright{} 2017 Federico address@hidden
 Copyright @copyright{} 2017 Carlo address@hidden
@@ -15735,6 +15735,12 @@ generation, the initial certification request to the 
Let's Encrypt
 service, the web server challenge/response integration, writing the
 certificate to disk, and the automated periodic renewals.
 
+Certbot is run twice a day, at a random minute within the hour.  It
+won't do anything until your certificates are due for renewal or
+revoked, but running it regularly would give your service a chance of
+staying online in case a Let's Encrypt-initiated revocation happened for
+some reason.
+
 @defvr {Scheme Variable} certbot-service-type
 A service type for the @code{certbot} Let's Encrypt client.
 @end defvr
diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
index 91249ed..1728d12 100644
--- a/gnu/services/certbot.scm
+++ b/gnu/services/certbot.scm
@@ -65,10 +65,10 @@
        (() '())
        (_
         (list
-         ;; Attempt to renew the certificates twice a week.
-         #~(job (lambda (now)
-                  (next-day-from (next-hour-from now '(3))
-                                 '(2 5)))
+         ;; Attempt to renew the certificates twice per day, at a random
+         ;; minute within the hour.  See
+         ;; https://certbot.eff.org/all-instructions/.
+         #~(job '(next-minute-from (next-hour '(0 12)) (list (random 60)))
                 (string-append #$package "/bin/certbot renew"
                                (string-concatenate
                                 (map (lambda (host)